Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Centos8 instead Centos7 for Helix tests #46205

Merged
merged 4 commits into from
Jan 5, 2021
Merged

Use Centos8 instead Centos7 for Helix tests #46205

merged 4 commits into from
Jan 5, 2021

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Dec 18, 2020

I updated tests runs to use Centos8 instead of Centos7.
I keept RedHat7 in place.
With that we should be able to get better test coverage.
(even if now running only in container)

fixes #972

@wfurt wfurt requested review from tmds, MattGal and safern December 18, 2020 00:02
@ghost
Copy link

ghost commented Dec 18, 2020

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

I updated tests runs to use Centos8 instead of Centos7.
I keept RedHat7 in place.
With that we should be able to get better test coverage.
(even if now running only in container)

fixes #972

Author: wfurt
Assignees: -
Labels:

area-Infrastructure
Milestone: -

@jkoritzinsky
Copy link
Member

Given that CentOS 8 goes out of support in under a year, do we want to move the RedHat 7 leg to RedHat 8 and keep the CentOS leg at CentOS 7?

@wfurt
Copy link
Member Author

wfurt commented Dec 18, 2020

we may eventually. But there is are still some lingering questions about ARM and year it long time. Getting Centos 8 into container was fastest and easiest for now to get at least some coverage.

@wfurt
Copy link
Member Author

wfurt commented Dec 18, 2020 

/root/helix/work/workitem /root/helix/work/workitem
Process terminated. Couldn't find a valid ICU package installed on the system. Set the configuration flag System.Globalization.Invariant to true if you want to run with no globalization support.
   at System.Environment.FailFast(System.String)
   at System.Globalization.GlobalizationMode.GetGlobalizationInvariantMode()

The image seems to have issue with globalization @MattGal . I'll take a look tomorrow.

@jkotas jkotas changed the title use Centos8 instead Centos8 for Helix tests Use Centos8 instead Centos7 for Helix tests Dec 18, 2020
This was referenced Dec 18, 2020
Closed
Closed
MattGal
MattGal approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the tests pass on the updated OS.

@MattGal
Copy link
Member

MattGal commented Dec 28, 2020

Looks like the image or a test needs to be updated for OpenSSL stuff:

    System.Net.Security.Tests.ServerNoEncryptionTest.ServerNoEncryption_ClientNoEncryption_ConnectWithNoEncryption [FAIL]
      Assert.IsType() Failure
      Expected: System.PlatformNotSupportedException
      Actual:   Interop+OpenSsl+SslException
      Stack Trace:
        /_/src/libraries/System.Net.Security/tests/FunctionalTests/ServerNoEncryptionTest.cs(99,0): at System.Net.Security.Tests.ServerNoEncryptionTest.ServerNoEncryption_ClientNoEncryption_ConnectWithNoEncryption()
        --- End of stack trace from previous location ---
    System.Net.Security.Tests.ServerAllowNoEncryptionTest.ServerAllowNoEncryption_ClientNoEncryption_ConnectWithNoEncryption [SKIP]
      Condition(s) not met: "SupportsNullEncryption"
  Finished:    System.Net.Security.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Security.Tests  Total: 4832, Errors: 0, Failed: 1, Skipped: 8, Time: 23.954s
/root/helix/work/workitem
----- end Fri Dec 18 23:59:13 UTC 2020 ----- exit code 1 ----------------------------------------------------------

@tmds
Copy link
Member

tmds commented Jan 4, 2021

👍 for adding a CentOS 8 build to increase coverage.
We can see how things evolve with CentOS 8 Stream, and decide to adopt Stream or use RHEL 8 instead later.

cc @omajid

@wfurt
Copy link
Member Author

wfurt commented Jan 5, 2021

CI all clean now to get some test coverage. We can make updates later as we see fit.

@wfurt wfurt merged commit f91f39c into dotnet:master Jan 5, 2021
@wfurt wfurt deleted the centos8_972 branch January 5, 2021 20:29
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern approved these changes

@MattGal MattGal MattGal approved these changes

@tmds tmds Awaiting requested review from tmds

Assignees
No one assigned
Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add test queue for RedHat 8
6 participants
@wfurt @jkoritzinsky @MattGal @tmds @safern @Dotnet-GitSync-Bot